Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracestate + baggage todos #894

Merged
merged 3 commits into from
Dec 12, 2022
Merged

tracestate + baggage todos #894

merged 3 commits into from
Dec 12, 2022

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Dec 12, 2022

remove baggage TODOs which have since been done.
implement TODOs from tracestate to log warnings.
tidy up tracestate code, simplify some const names.

@brettmc brettmc requested a review from a team as a code owner December 12, 2022 02:51
@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #894 (31c30c0) into main (602ea85) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #894   +/-   ##
=========================================
  Coverage     80.90%   80.90%           
+ Complexity     1906     1905    -1     
=========================================
  Files           252      252           
  Lines          4932     4932           
=========================================
  Hits           3990     3990           
  Misses          942      942           
Flag Coverage Δ
7.4 80.35% <100.00%> (ø)
8.0 80.88% <100.00%> (ø)
8.1 81.02% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/API/Trace/TraceState.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 602ea85...31c30c0. Read the comment docs.

@brettmc brettmc merged commit 616b356 into open-telemetry:main Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants