Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checks for markdown files as we have in the spec repo #464

Closed
joaopgrassi opened this issue May 4, 2023 · 1 comment
Closed

Add checks for markdown files as we have in the spec repo #464

joaopgrassi opened this issue May 4, 2023 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@joaopgrassi
Copy link
Member

With the merge of https://github.com/open-telemetry/opentelemetry-proto/pull/457/files, now we have "more" markdown files in this repo.

While working on #463 I noticed we don't have the same tooling for validating/generating markdown "stuff" in the Make file. Also no checks for it in github actions
@joaopgrassi joaopgrassi changed the title Add markdown checks in the make file Add checks for markdown files as we have in the spec repo May 4, 2023
@arminru arminru added the help wanted Extra attention is needed label May 9, 2023
@bogdandrutu bogdandrutu added the good first issue Good for newcomers label May 22, 2023
jaydeluca added a commit to jaydeluca/opentelemetry-proto that referenced this issue Jul 4, 2023
@jaydeluca
add markdown linting to makefile and github actions (reference: open-…
2287a49 
…telemetry#464)
This was referenced Jul 4, 2023
Closed
Merged
tigrannajaryan pushed a commit that referenced this issue Jul 19, 2023
@jaydeluca @tigrannajaryan
add markdown linting to makefile and github actions (reference: #464)
199d94d
@tigrannajaryan
Copy link
Member

Completed in #494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bogdandrutu @tigrannajaryan @joaopgrassi @arminru