Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move examples out of spec into an examples folder #471

Closed
chalin opened this issue May 11, 2023 · 1 comment · Fixed by #472
Closed

Move examples out of spec into an examples folder #471

chalin opened this issue May 11, 2023 · 1 comment · Fixed by #472

Comments

@chalin
Copy link
Contributor

chalin commented May 11, 2023

This is a followup to:

@tigrannajaryan @joaopgrassi, et al.: In #463, the examples were added to the spec, is that because the examples are they meant to be binding / enforce some sort of specification-related conformance? If not, they should be moved out of the spec folder IMHO, into, say, an examples folder.

Keep in mind that everything in the spec folder (hopefully to be renamed to docs via #469), will soon be published to the OTel website.

/cc @svrnm @cartermp

@joaopgrassi
Copy link
Member

Hey @chalin

No, they are just examples nothing enforcing. I think it would be ok in moving them to another folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants