Rename ./specification to ./docs #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
|
Is this necessary for website publishing or you are just proposing an improvement in the structure? |
|
Both (since they are related). |
tigrannajaryan
approved these changes
May 9, 2023
cartermp
approved these changes
May 9, 2023
|
@open-telemetry/specs-approvers please review, this blocks website work. |
svrnm
approved these changes
May 11, 2023
|
lgtm |
chalin
force-pushed
the
chalin-im-name-docs-folder-2023-05-09
branch
from
23cef6d
to
cb1ab40
Compare
|
On hold until the following is resolved: |
chalin
force-pushed
the
chalin-im-name-docs-folder-2023-05-09
branch
from
cb1ab40
to
8263ca3
Compare
|
chalin
force-pushed
the
chalin-im-name-docs-folder-2023-05-09
branch
3 times, most recently
from
5e90662
to
75af5a2
Compare
|
@chalin please resolve the conflicts. |
chalin
force-pushed
the
chalin-im-name-docs-folder-2023-05-09
branch
from
75af5a2
to
c17aabc
Compare
chalin
force-pushed
the
chalin-im-name-docs-folder-2023-05-09
branch
from
c17aabc
to
5bf53ba
Compare
@tigrannajaryan - done: |
|
@open-telemetry/specs-approvers please take a look. |
carlosalberto
approved these changes
May 19, 2023
|
@chalin Sorry for the late review ;( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @tigrannajaryan @svrnm @cartermp et al.,
Why this PR? Because the documented OTLP specification is strictly contained within
./specification/otlp.md. The remaining pages under./specificationare supporting documentation. So, in this PR I propose the following:./specificationto./docsspecification/otlp.mdto./docs/specification.mdThoughts?
Contributes to:
/cc @open-telemetry/specs-approvers