Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The comment of schema_url doesn't describe it's purpose. #502

Closed
MadVikingGod opened this issue Aug 4, 2023 · 0 comments · Fixed by #504
Closed

The comment of schema_url doesn't describe it's purpose. #502

MadVikingGod opened this issue Aug 4, 2023 · 0 comments · Fixed by #504

Comments

@MadVikingGod
Copy link

Six places in the proto define a schema_url, but none of them have a comment describing what should be contained by this string. They only include where it applies to:

// This schema_url applies to all metrics in the "metrics" field.

This has led to confusion by users about what should be used there. https://cloud-native.slack.com/archives/C01NPAXACKT/p1691165635060229?thread_ts=1690392036.272789&cid=C01NPAXACKT

We should include a short description of what the schema_url is.
tigrannajaryan added a commit to tigrannajaryan/opentelemetry-proto that referenced this issue Aug 17, 2023
@tigrannajaryan
Add comment to explain schema_url fields
dfa2a7f 
Resolves open-telemetry#502
@tigrannajaryan tigrannajaryan mentioned this issue Aug 17, 2023
Merged
tigrannajaryan added a commit to tigrannajaryan/opentelemetry-proto that referenced this issue Aug 23, 2023
@tigrannajaryan
Add comment to explain schema_url fields
e150ad3 
Resolves open-telemetry#502
tigrannajaryan added a commit that referenced this issue Aug 23, 2023
@tigrannajaryan
Add comment to explain schema_url fields
d1468b7 
Resolves #502
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add comment to explain schema_url fields tigrannajaryan/opentelemetry-proto
1 participant
@MadVikingGod