Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix releasing notes #508

Closed
jack-berg opened this issue Oct 5, 2023 · 3 comments · Fixed by #548
Closed

Fix releasing notes #508

jack-berg opened this issue Oct 5, 2023 · 3 comments · Fixed by #548

Comments

@jack-berg
Copy link
Member

The RELEASING.md notes reference creating release branches which don't appear to exist: https://github.com/open-telemetry/opentelemetry-proto/branches

Can someone who has recently performed the release update the notes with the process?

Ran into this because we copied the releasing workflow for opentelemetry-configuration and ran into missing branch protection rules.

@arminru
Copy link
Member

arminru commented Oct 10, 2023

I think we'll also have to create a tag protection rule here:
https://github.com/open-telemetry/opentelemetry-proto/settings/tag_protection

@arminru
Copy link
Member

arminru commented Oct 10, 2023

@tigrannajaryan can you take a look?
Otherwise I can also update the docs and add a rule as described.

@tigrannajaryan
Copy link
Member

We don't do release branches. We use the release function in github which adds tags.

tigrannajaryan added a commit to tigrannajaryan/opentelemetry-proto that referenced this issue Apr 24, 2024
The document is outdated. We are now using Github's release feature.

Resolves open-telemetry#508
tigrannajaryan added a commit to tigrannajaryan/opentelemetry-proto that referenced this issue Apr 25, 2024
The document is outdated. We are now using Github's release feature.

Resolves open-telemetry#508
tigrannajaryan added a commit that referenced this issue May 7, 2024
The document is outdated. We are now using Github's release feature.

Resolves #508

Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants