Stop checking-in generated Golang code #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The OTel-Go fix: open-telemetry/opentelemetry-go#942 |
jmacd
changed the title
|
Can we gate this on a release of the Go SIG library to ensure downstream has a versoned source for this code? I can get this release done this afternoon. |
bogdandrutu
approved these changes
Jul 20, 2020
MrAlias
approved these changes
Jul 20, 2020
yurishkuro
approved these changes
Jul 20, 2020
|
@MrAlias Is there going to be a problem? I would have assumed the Go dependency was pinned to an older release that had the generated code. |
|
@MrAlias sorry, didn't notice your comment. Hope it's not a problem, can revert if it is. |
Should be okay, not worth a revert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this will fix the build in all the open PRs.
I believe both the OTel-Go SDK and Collector have stopped using these generated files.
Resolves #79