Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error to span, deprecate status #174

Closed
wants to merge 1 commit into from
Closed

Add error to span, deprecate status #174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion opentelemetry/proto/trace/v1/trace.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,14 @@ message Span {
// An optional final status for this span. Semantically when Status
// wasn't set it is means span ended without errors and assume
// Status.Ok (code = 0).
Status status = 15;
//
// This field is being deprecated in favour of the
// error field combined with semantic conventions of attributes
// containing additional details on the error that occurred
Status status = 15 [deprecated = true];

// error is a field to indicate if the span contained an error
bool error = 16;
}

// The Status type defines a logical error model that is suitable for different
Expand Down