Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fixed64 and sfixed64 for the sums and counts #214

Merged
merged 1 commit into from
Aug 29, 2020
Merged

Use fixed64 and sfixed64 for the sums and counts #214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions opentelemetry/proto/metrics/v1/metrics.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ message IntDataPoint {
fixed64 time_unix_nano = 3;

// value itself.
int64 value = 4;
sfixed64 value = 4;

// (Optional) List of exemplars collected from
// measurements that were used to form the data point
Expand Down Expand Up @@ -387,12 +387,12 @@ message IntHistogramDataPoint {
// count is the number of values in the population. Must be non-negative. This
// value must be equal to the sum of the "count" fields in buckets if a
// histogram is provided.
uint64 count = 4;
fixed64 count = 4;

// sum of the values in the population. If count is zero then this field
// must be zero. This value must be equal to the sum of the "sum" fields in
// buckets if a histogram is provided.
int64 sum = 5;
sfixed64 sum = 5;

// bucket_counts is an optional field contains the count values of histogram
// for each bucket.
Expand All @@ -401,7 +401,7 @@ message IntHistogramDataPoint {
//
// The number of elements in bucket_counts array must be by one greater than
// the number of elements in explicit_bounds array.
repeated uint64 bucket_counts = 6;
repeated fixed64 bucket_counts = 6;

// A histogram may optionally contain the distribution of the values in the population.
// In that case one of the option fields below and "buckets" field both must be defined.
Expand Down Expand Up @@ -463,7 +463,7 @@ message DoubleHistogramDataPoint {
// count is the number of values in the population. Must be non-negative. This
// value must be equal to the sum of the "count" fields in buckets if a
// histogram is provided.
uint64 count = 4;
fixed64 count = 4;

// sum of the values in the population. If count is zero then this field
// must be zero. This value must be equal to the sum of the "sum" fields in
Expand All @@ -477,7 +477,7 @@ message DoubleHistogramDataPoint {
//
// The number of elements in bucket_counts array must be by one greater than
// the number of elements in explicit_bounds array.
repeated uint64 bucket_counts = 6;
repeated fixed64 bucket_counts = 6;

// A histogram may optionally contain the distribution of the values in the population.
// In that case one of the option fields below and "buckets" field both must be defined.
Expand Down Expand Up @@ -525,7 +525,7 @@ message IntExemplar {
fixed64 time_unix_nano = 2;

// Numerical int value of the measurement that was recorded.
int64 value = 3;
sfixed64 value = 3;

// (Optional) Span ID of the exemplar trace.
// span_id may be missing if the measurement is not recorded inside a trace
Expand Down