Add optional data point flags to all metrics data points, support staleness markers #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
changed the title
weyert
approved these changes
Jun 23, 2021
carlosalberto
approved these changes
Jun 23, 2021
jsuereth
approved these changes
Jun 30, 2021
|
@bogdandrutu @open-telemetry/specs-metrics-approvers Please take a look. |
reyang
approved these changes
Aug 3, 2021
cijothomas
approved these changes
Aug 3, 2021
bogdandrutu
reviewed
Aug 5, 2021
There was a problem hiding this comment.
LGTM, except one question:
In protobuf is the enum equivalent with an "int32"? If not how would we intend to add new values? An enum has the property that only one value can be sent, if we add a new bit "foo" then are we going to change them to 4 new values NO_FOO_NONE, NO_FOO_NO_RECORD, FOO_NONE, etc.?
Do we need the value in the points to be uint32 and the enum be the bitset mask? Probably I am missing something...
|
@jmacd also this needs a rebase |
Yes, see https://developers.google.com/protocol-buffers/docs/proto3#enum |
|
I switched this to |
MrAlias
approved these changes
Aug 6, 2021
tigrannajaryan
approved these changes
Aug 9, 2021
|
🎉 |
Merged
5 tasks
carlosalberto
pushed a commit
to open-telemetry/opentelemetry-specification
that referenced
this pull request
Aug 8, 2024
Fixes #4053 ## Changes This PR extends the metric data model with data point flags, which were added to the protocol in open-telemetry/opentelemetry-proto#316.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a bit to represent stale points they way Prometheus does when scraping for metrics yields no results. This avoids the use of IEEE 754 NaN values in data points that do not necessarily have a floating point field that can be used.
Resolves #315.
Related: open-telemetry/opentelemetry-specification#1078
Partial copy from #310.
Resolves #309.