-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename AnyValue to Value, this should not be on the wire breaking change #429
Conversation
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
The "breaking change" steps seems super cool, but I fail to understand how that fails with this change. See https://github.com/open-telemetry/opentelemetry-proto/actions/runs/3070753656/jobs/4960806704 |
I understand now:
We are using |
what is the motivation for this change? or is it just an experiment? |
Initially I thought that the name may improve usability, so wanted to create a PR to hear opinions, but now I am intrigued about the rules. |
We are probably using a wrong setting. I think we should use As for the specific change I am not sure that the new name is better. If we ever add any other value type in the future it can become confusing. We also reference to Given that this change is also going to cause pains for users of the proto's generated code I would prefer to keep the current name. |
@tigrannajaryan I was not sold on the name, I was hacking around to see how the new name looks and found that I break the requirements, and that triggered me to create the PR. |
It is set up to use WIRE: Line 6 in 724e427
I think the check just doesn't recognize the rename and so thinks the field type changed, see bufbuild/buf#609. However, I suppose changing the name would be a wire breaking change if the message appears in an |
@bogdandrutu anything further to discuss on this? I think the discovery is that tool is not properly detecting that it is just a renaming, so let's be aware of it for any future change. However, it also seems that we are not going forward with the proposed renaming, so close the PR? |
Message names are not used in JSON or Protobuf encoding, so this is a no-op for both json and proto wire encoding.
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com