Split common package into value and scope

[bogdandrutu]

This is a no-op for generated code, but helps within the collector pdata where we want to replace the generated code for the value (remove the entire value file essentially).

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

[tigrannajaryan]

Please add a link to Collector pdata issue that requires this change.

[yurishkuro]

This is a no-op for generated code

Are you sure? May have different effect in different languages, e.g. produce scope.py/value.py in Python that must be imported separately (not saying it would be a reason not to do this).

[bogdandrutu]

Are you sure? May have different effect in different languages, e.g. produce scope.py/value.py in Python that must be imported separately (not saying it would be a reason not to do this).

You are right, did not think about this. Probably not worth it then. I will do a hack on the collector.

[bogdandrutu]

@jsuereth @tigrannajaryan since you want to declare proto 1.0, I want to document if this change is considered a breaking change or not.

[jsuereth]

I would like to NOT consider this a breaking change, but I'd also like to avoid changes like this post 1.0.

The cost of cosmetic changes like this can often outweigh the benefits, even in the long run. However, at this time, I think this may be the last point in time where I'd be supportive of a change like this.

[tigrannajaryan]

Are you sure? May have different effect in different languages, e.g. produce scope.py/value.py in Python that must be imported separately (not saying it would be a reason not to do this).

You are right, did not think about this. Probably not worth it then. I will do a hack on the collector.

Closing this since @bogdandrutu no longer needs it.

@jsuereth @tigrannajaryan since you want to declare proto 1.0, I want to document if this change is considered a breaking change or not.

I think this is considered a breaking change in the proposed PR: #432

We can further discuss on that PR.