Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "example.com" where an example domain is needed #465

Merged
merged 1 commit into from
May 4, 2023
Merged

Use "example.com" where an example domain is needed #465

merged 1 commit into from
May 4, 2023

Conversation

aabmass
Copy link
Member

@aabmass aabmass commented May 4, 2023

example.com is reserved by IANA for example uses. abc.com is a real domain

@aabmass aabmass requested review from a team as code owners May 4, 2023 16:47
@reyang reyang merged commit c26513a into open-telemetry:main May 4, 2023
14 checks passed
@aabmass aabmass deleted the example-domain branch May 4, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@reyang reyang reyang approved these changes

Assignees

@jmacd jmacd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aabmass @tigrannajaryan @reyang @jmacd