Fix JSON field capitalization in trace.json example #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indirectly related to open-telemetry#476 The spec requires that: >The keys of JSON objects are field names converted to lowerCamelCase. See https://github.com/open-telemetry/opentelemetry-proto/blob/main/docs/specification.md#json-protobuf-encoding
joaopgrassi
approved these changes
May 23, 2023
arminru
approved these changes
May 23, 2023
There was a problem hiding this comment.
LGTM!
I also verified that both options work in the collector:
https://github.com/open-telemetry/opentelemetry-collector/blob/ae8c63ae3ff532dc496c803cbcd97148e3deaf13/pdata/ptrace/json.go#L44
https://github.com/open-telemetry/opentelemetry-collector/blob/ae8c63ae3ff532dc496c803cbcd97148e3deaf13/pdata/ptrace/json.go#L61
carlosalberto
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indirectly related to #476
The spec requires that:
See https://github.com/open-telemetry/opentelemetry-proto/blob/main/docs/specification.md#json-protobuf-encoding