Skip to content

Commit

Permalink
Fix lint
Browse files Browse the repository at this point in the history
  • Loading branch information
shalevr committed Oct 2, 2022
1 parent f579964 commit 44fa143
Showing 1 changed file with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def sorted_metrics(metrics):
key=lambda m: m.name,
)

def assertMetricExpected(
def assert_metric_expected(
self, metric, expected_value, expected_attributes
):
data_point = next(metric.data.data_points)
Expand All @@ -75,7 +75,7 @@ def assertMetricExpected(
dict(data_point.attributes),
)

def assertDurationMetricExpected(
def assert_duration_metric_expected(
self, metric, duration_estimated, expected_attributes
):
data_point = next(metric.data.data_points)
Expand Down Expand Up @@ -130,7 +130,7 @@ def test_basic_metrics(self):
self.assertEqual(
server_active_request.name, "http.server.active_requests"
)
self.assertMetricExpected(
self.assert_metric_expected(
server_active_request,
0,
{
Expand All @@ -143,7 +143,7 @@ def test_basic_metrics(self):
)

self.assertEqual(server_duration.name, "http.server.duration")
self.assertDurationMetricExpected(
self.assert_duration_metric_expected(
server_duration,
client_duration_estimated,
{
Expand All @@ -157,7 +157,7 @@ def test_basic_metrics(self):
)

self.assertEqual(server_request_size.name, "http.server.request.size")
self.assertMetricExpected(
self.assert_metric_expected(
server_request_size,
0,
{
Expand All @@ -173,7 +173,7 @@ def test_basic_metrics(self):
self.assertEqual(
server_response_size.name, "http.server.response.size"
)
self.assertMetricExpected(
self.assert_metric_expected(
server_response_size,
len(response.body),
{
Expand All @@ -187,7 +187,7 @@ def test_basic_metrics(self):
)

self.assertEqual(client_duration.name, "http.client.duration")
self.assertDurationMetricExpected(
self.assert_duration_metric_expected(
client_duration,
client_duration_estimated,
{
Expand All @@ -198,7 +198,7 @@ def test_basic_metrics(self):
)

self.assertEqual(client_request_size.name, "http.client.request.size")
self.assertMetricExpected(
self.assert_metric_expected(
client_request_size,
0,
{
Expand All @@ -211,7 +211,7 @@ def test_basic_metrics(self):
self.assertEqual(
client_response_size.name, "http.client.response.size"
)
self.assertMetricExpected(
self.assert_metric_expected(
client_response_size,
len(response.body),
{
Expand Down

0 comments on commit 44fa143

Please sign in to comment.