lazy loading for log messages

open-telemetry · Jul 23, 2021 · 530a91b · 530a91b
1 parent 9cd22df
commit 530a91b
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 8 deletions.
diff --git a/...n/opentelemetry-sdk-extension-aws/src/opentelemetry/sdk/extension/aws/resource/_lambda.py b/...n/opentelemetry-sdk-extension-aws/src/opentelemetry/sdk/extension/aws/resource/_lambda.py
@@ -58,5 +58,5 @@ def detect(self) -> "Resource":
             if self.raise_on_error:
                 raise exception
 
-            logger.warning(f"{self.__class__.__name__} failed: {exception}")
+            logger.warning("%s failed: %s", self.__class__.__name__, exception)
             return Resource.get_empty()
diff --git a/...opentelemetry-sdk-extension-aws/src/opentelemetry/sdk/extension/aws/resource/beanstalk.py b/...opentelemetry-sdk-extension-aws/src/opentelemetry/sdk/extension/aws/resource/beanstalk.py
@@ -66,5 +66,5 @@ def detect(self) -> "Resource":
             if self.raise_on_error:
                 raise exception
 
-            logger.warning(f"{self.__class__.__name__} failed: {exception}")
+            logger.warning("%s failed: %s", self.__class__.__name__, exception)
             return Resource.get_empty()
diff --git a/...nsion/opentelemetry-sdk-extension-aws/src/opentelemetry/sdk/extension/aws/resource/ec2.py b/...nsion/opentelemetry-sdk-extension-aws/src/opentelemetry/sdk/extension/aws/resource/ec2.py
@@ -99,5 +99,5 @@ def detect(self) -> "Resource":
             if self.raise_on_error:
                 raise exception
 
-            logger.warning(f"{self.__class__.__name__} failed: {exception}")
+            logger.warning("%s failed: %s", self.__class__.__name__, exception)
             return Resource.get_empty()
diff --git a/...nsion/opentelemetry-sdk-extension-aws/src/opentelemetry/sdk/extension/aws/resource/ecs.py b/...nsion/opentelemetry-sdk-extension-aws/src/opentelemetry/sdk/extension/aws/resource/ecs.py
@@ -53,8 +53,7 @@ def detect(self) -> "Resource":
                             container_id = line[-_CONTAINER_ID_LENGTH:]
             except FileNotFoundError as exception:
                 logger.warning(
-                    "Failed to get container ID on ECS: %s.",
-                    exception,
+                    "Failed to get container ID on ECS: %s.", exception
                 )
 
             return Resource(
@@ -70,5 +69,5 @@ def detect(self) -> "Resource":
             if self.raise_on_error:
                 raise exception
 
-            logger.warning(f"{self.__class__.__name__} failed: {exception}")
+            logger.warning("%s failed: %s", self.__class__.__name__, exception)
             return Resource.get_empty()
diff --git a/...nsion/opentelemetry-sdk-extension-aws/src/opentelemetry/sdk/extension/aws/resource/eks.py b/...nsion/opentelemetry-sdk-extension-aws/src/opentelemetry/sdk/extension/aws/resource/eks.py
@@ -38,7 +38,9 @@ def _aws_http_request(method, path, cred_value):
             method=method,
         ),
         timeout=2000,
-        context=ssl.create_default_context(cafile="/var/run/secrets/kubernetes.io/serviceaccount/ca.crt"),
+        context=ssl.create_default_context(
+            cafile="/var/run/secrets/kubernetes.io/serviceaccount/ca.crt"
+        ),
     ) as response:
         return response.read().decode("utf-8")
 
@@ -127,5 +129,5 @@ def detect(self) -> "Resource":
             if self.raise_on_error:
                 raise exception
 
-            logger.warning(f"{self.__class__.__name__} failed: {exception}")
+            logger.warning("%s failed: %s", self.__class__.__name__, exception)
             return Resource.get_empty()