Skip to content

Commit

Permalink
Made function name uniform
Browse files Browse the repository at this point in the history
  • Loading branch information
Ryo Kather committed Jun 7, 2021
1 parent 441a0df commit 7558742
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ async def do_request(url):
)
self.memory_exporter.clear()

def test_credentials(self):
def test_credential_removal(self):
trace_configs = [aiohttp_client.create_trace_config()]

url = "http://username:password@httpbin.org/"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ def test_invalid_url(self):
)
self.assertEqual(span.status.status_code, StatusCode.ERROR)

def test_url_credentials(self):
def test_credential_removal(self):
new_url = "http://username:password@httpbin.org/status/200"
self.perform_request(new_url)
span = self.assert_span()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -455,6 +455,9 @@ def test_response_headers(self):
self.memory_exporter.clear()
set_global_response_propagator(orig)

def test_credential_removal(self):
pass


class TornadoHookTest(TornadoTest):
_client_request_hook = None
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ def test_requests_timeout_exception(self, *_, **__):
span = self.assert_span()
self.assertEqual(span.status.status_code, StatusCode.ERROR)

def test_credentials_url(self):
def test_credential_removal(self):
url = "http://username:password@httpbin.org/status/200"

with self.assertRaises(Exception):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ def url_filter(url):
response = self.perform_request(self.HTTP_URL + "?e=mcc")
self.assert_success_span(response, self.HTTP_URL)

def test_url_credential_removal(self):
def test_credential_removal(self):
url = "http://username:password@httpbin.org/status/200"

response = self.perform_request(url)
Expand Down

0 comments on commit 7558742

Please sign in to comment.