linting fixes and CHANGELOG update

open-telemetry · Oct 5, 2021 · 7baaea4 · 7baaea4
1 parent 38d38d4
commit 7baaea4
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -20,6 +20,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   ([#686](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/686))
 - `opentelemetry-instrumentation-tornado` now sets `http.client_ip` and `tornado.handler` attributes
   ([#706](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/706))
+- `opentelemetry-instrumentation-requests` added `tracked_url_callback`
+  ([#714](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/714))
 
 ### Changed
 - `opentelemetry-instrumentation-botocore` Unpatch botocore Endpoint.prepare_request on uninstrument

diff --git a/...telemetry-instrumentation-requests/src/opentelemetry/instrumentation/requests/__init__.py b/...telemetry-instrumentation-requests/src/opentelemetry/instrumentation/requests/__init__.py
@@ -65,10 +65,7 @@
 # pylint: disable=unused-argument
 # pylint: disable=R0915
 def _instrument(
-    tracer, 
-    span_callback=None, 
-    name_callback=None, 
-    tracked_url_callback=None,
+    tracer, span_callback=None, name_callback=None, tracked_url_callback=None
 ):
     """Enables tracing of all requests calls that go through
     :code:`requests.session.Session.request` (this includes

diff --git a/instrumentation/opentelemetry-instrumentation-requests/tests/test_requests_integration.py b/instrumentation/opentelemetry-instrumentation-requests/tests/test_requests_integration.py
@@ -130,11 +130,14 @@ def test_tracked_url_callback(self):
         httpretty.register_uri(
             httpretty.GET, url_404, status=404,
         )
+
         def tracked_url_callback(method, url):
             return "404" not in url
 
         RequestsInstrumentor().uninstrument()
-        RequestsInstrumentor().instrument(tracked_url_callback=tracked_url_callback)
+        RequestsInstrumentor().instrument(
+            tracked_url_callback=tracked_url_callback
+        )
         self.perform_request(self.URL)
         self.perform_request(url_404)
 
@@ -271,7 +274,7 @@ def span_callback(span, result: requests.Response):
             {
                 SpanAttributes.HTTP_METHOD: "GET",
                 SpanAttributes.HTTP_URL: self.URL,
-                SpanAttributes.HTTP_STATUS_CODE: 200, 
+                SpanAttributes.HTTP_STATUS_CODE: 200,
                 "http.response.body": "Hello!",
             },
         )