Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need Unit Tests for gRPC server instrumentation #173

Closed
NathanielRN opened this issue Oct 31, 2020 · 0 comments · Fixed by #236
Closed

Need Unit Tests for gRPC server instrumentation #173

NathanielRN opened this issue Oct 31, 2020 · 0 comments · Fixed by #236

Comments

@NathanielRN
Copy link
Contributor

In PR open-telemetry/opentelemetry-python#1308 the Spans created as part of instrumenting gRPC were corrected to use the error codes as recently updated in the OTel Specifications instead of the gRPC error codes.

This didn't break any unit tests which is not ideal, we should add unit tests so that changes like these are flagged in the tests and require a test change.

@codeboten codeboten transferred this issue from open-telemetry/opentelemetry-python Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant