Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure rpc instrumentations follow semantic conventions #139

Closed
lzchen opened this issue Oct 28, 2020 · 1 comment · Fixed by #236
Closed

Make sure rpc instrumentations follow semantic conventions #139

lzchen opened this issue Oct 28, 2020 · 1 comment · Fixed by #236
Assignees
@alertedsnake
Labels
good first issue Good for newcomers help wanted Extra attention is needed instrumentation required-for-ga item is required for general availablity release

Comments

@lzchen
Copy link
Contributor

lzchen commented Oct 28, 2020

Specs: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/rpc.md
srikanthccv referenced this issue in srikanthccv/opentelemetry-python Nov 1, 2020
@renovate-bot @mayurkale22
chore(deps): update dependency webpack-merge to v5 (#1300)
6b34f3e 
Co-authored-by: Mayur Kale <mayurkale@google.com>
@codeboten codeboten transferred this issue from open-telemetry/opentelemetry-python Nov 5, 2020
@codeboten codeboten added instrumentation good first issue Good for newcomers help wanted Extra attention is needed required-for-ga item is required for general availablity release labels Nov 5, 2020
@alertedsnake
Copy link
Contributor

I'm on this one - I did most of the re-implementation anyway, and it was pretty easy to do.
Will have a PR up as soon as I look into #173 as well.

alertedsnake pushed a commit to alertedsnake/opentelemetry-python-contrib that referenced this issue Dec 5, 2020
Update gRPC instrumentation to comply with spec
e919daa 
For open-telemetry#139 - some of these things weren't as clear before.
@alertedsnake alertedsnake mentioned this issue Dec 5, 2020
Merged
9 tasks
alertedsnake pushed a commit to alertedsnake/opentelemetry-python-contrib that referenced this issue Dec 10, 2020
Update gRPC instrumentation to comply with spec
7271cde 
For open-telemetry#139 - some of these things weren't as clear before.
alertedsnake pushed a commit to alertedsnake/opentelemetry-python-contrib that referenced this issue Dec 10, 2020
Update gRPC instrumentation to comply with spec
0193cb6 
For open-telemetry#139 - some of these things weren't as clear before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alertedsnake alertedsnake

Labels
good first issue Good for newcomers help wanted Extra attention is needed instrumentation required-for-ga item is required for general availablity release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add more tests, fix compliance to semantics alertedsnake/opentelemetry-python-contrib
3 participants
@codeboten @alertedsnake @lzchen