Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to specify which distro and configurator to use in auto instrumentation #1822

Closed
jeremydvoss opened this issue May 23, 2023 · 0 comments · Fixed by #1823
Closed

Comments

@jeremydvoss
Copy link
Contributor

Is your feature request related to a problem?
Yes. Currently, if a user has multiple packages with distro or configurator entry points installed, they have no control over which are used for the auto instrumentation flow.

Describe the solution you'd like
Copying what we do for exporters, I am adding 2 env vars where users can specify the entry point names of the distros and configurators they want used. I added warnings for each distro and configurator not used.

Describe alternatives you've considered
I considered requiring thes environment variables to be used but instead chose to make them optional. If the env vars are not set, then existing behavior continues: the first distro and configurators found will be used.

Additional context
With the way the package is set up, this also adds the --distro and --configurator command line args. Also, we currently have not tests for the sitecustomize file. I found it tricky to implement because importing the module triggers instrumentation. Open to suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant