Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WSGI: Conditionally create SERVER spans #454

Closed
owais opened this issue Apr 15, 2021 · 2 comments
Closed

WSGI: Conditionally create SERVER spans #454

owais opened this issue Apr 15, 2021 · 2 comments
Assignees
@sanketmehta28
Labels
feature-request help wanted Extra attention is needed instrumentation

Comments

@owais
Copy link
Contributor

owais commented Apr 15, 2021

Part of #445
@owais owais added feature-request good first issue Good for newcomers help wanted Extra attention is needed instrumentation labels Apr 15, 2021
@owais owais removed the good first issue Good for newcomers label Oct 3, 2021
@sanketmehta28
Copy link
Member

@owais : can you please assign it to me?

sanketmehta28 added a commit to sanketmehta28/opentelemetry-python-contrib that referenced this issue Feb 5, 2022
@sanketmehta28
code changes to resolve conditional server span creation for WSGI (op…
190f562 
…en-telemetry#454)
@sanketmehta28 sanketmehta28 mentioned this issue Feb 5, 2022
Merged
6 tasks
ocelotl pushed a commit that referenced this issue Feb 9, 2022
@sanketmehta28
code changes to resolve conditional server span creation for WSGI and…
454f4b1 
… adding 'attributes' parameter to util function (#903)

* code changes to resolve conditional server span creation for WSGI (#454)

* Adding entry to changelog.md

* modifying _start_internal_or_server_span() to add attributes as a parameter. Also calling _start_internal_or_server_span() in WSGI instrumentation

* resolving flake8 and typo issues
@sanketmehta28
Copy link
Member

Hi @owais: you can close this one as PR has been merged for the same

@owais owais closed this as completed Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sanketmehta28 sanketmehta28

Labels
feature-request help wanted Extra attention is needed instrumentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@owais @sanketmehta28