Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing license and manifests to the instrumentation packages. #893

Closed
lzchen opened this issue Feb 2, 2022 · 8 comments · Fixed by #1244
Closed

Add missing license and manifests to the instrumentation packages. #893

lzchen opened this issue Feb 2, 2022 · 8 comments · Fixed by #1244
Assignees
Labels
bug Something isn't working

Comments

@lzchen
Copy link
Contributor

lzchen commented Feb 2, 2022

Continued from #616

@lzchen lzchen added the bug Something isn't working label Feb 2, 2022
@Sunilwali679
Copy link

@lzchen I am seeing the manifest file is missing in the below directory and it should be more . is this required to add the files in the below folder are not

https://github.com/open-telemetry/opentelemetry-python-contrib/tree/main/instrumentation/opentelemetry-instrumentation-confluent-kafka
https://github.com/open-telemetry/opentelemetry-python-contrib/tree/main/instrumentation/opentelemetry-instrumentation-starlette

can i work on this ??

@Sunilwali679
Copy link

can i work on this ??

@Sunilwali679
Copy link

can u please add as a contributor or co-author to this issue . We are from same community and working on this issue together .

"login": "rahuldimri",
"id": 107100022,

"login": "rahulhacker",
"id": 20458598,

@lzchen
Copy link
Contributor Author

lzchen commented Aug 22, 2022

@Sunilwali679
I believe those users have to comment on this issue for me to assign them as well.

@rahuldimri
Copy link
Contributor

As we are working with Sunil on this issue. Please assign this to me.

@rahulhacker
Copy link
Contributor

@lzchen : I am working with @Sunilwali679 on this issue, please assign this to me also

@srikanthccv
Copy link
Member

I think this is a trivial issue that doesn't require any actual code changes. I am not sure what three of you going to do here. Please just someone take this up and create one PR.

rahulhacker added a commit to fidelity/open-telemetry-opentelemetry-python-contrib that referenced this issue Aug 23, 2022
Co-authored-by: Sunil Sunilshidrayi.wali@fmr.com
Co-authored-by: Rahuldimri rahul.dimri@fmr.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants