Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC Instrumentation - Support of metrics, messages as span events, conformity to official grpc.ClientInterceptor and bug fixes #1227

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

CoLa5
Copy link
Contributor

@CoLa5 CoLa5 commented Aug 14, 2022

Description

Major Redesign of gRPC Instrumentation, including:

New Feature

Bug Fixes

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox -e test-instrumentation-grpc runs adapted instrumentation/opentelemetry-instrumentation-grpc/tests/test_client_interceptor.py and instrumentation/opentelemetry-instrumentation-grpc/tests/test_server_interceptor.py which test metrics, creation of span events and conformity of interfaces on client-side

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@CoLa5 CoLa5 marked this pull request as ready for review August 14, 2022 12:51
@CoLa5 CoLa5 requested a review from a team as a code owner August 14, 2022 12:51
@ocelotl
Copy link
Contributor

ocelotl commented Sep 22, 2022

Please fix conflicts

@srikanthccv
Copy link
Member

It's a lot to review all of these changes at once. Please split the PR into multiple PRs - one for each fix and a new enhancement. It's easier for reviewers that way.

@srikanthccv
Copy link
Member

@CoLa5 Please fix the conflicts and split the PR into smaller ones, ideally one of each change for faster reviews.

@CoLa5
Copy link
Contributor Author

CoLa5 commented Jan 13, 2023

Started with PR (#1578) for Issue (#855 )

@CoLa5
Copy link
Contributor Author

CoLa5 commented Jan 15, 2023

Requested (#1583)

@AVC0706
Copy link

AVC0706 commented Feb 6, 2023

Hey @CoLa5 is this feature merged and available in stable release?
If not can you please help me with some other third party package or extension that provides a solution for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants