Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture common HTTP attributes from API Gateway proxy events in Lambda instrumentor #1233

Conversation

finlaysawyer
Copy link
Contributor

@finlaysawyer finlaysawyer commented Aug 17, 2022

Description

This PR addresses part of #1087 to automatically capture common HTTP attributes from API Gateway events in the Lambda instrumentor.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit tests below added with events generated via sam local generate-event.
  • Deployment of a REST API & Lambda Function with the Lambda Instrumentor enabled. All attributes validated via the console span exporter.
  • Deployment of a HTTP API & Lambda Function with the Lambda Instrumentor enabled. All attributes validated via the console span exporter.

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 17, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: finlaysawyer / name: Finlay (576b969)

@finlaysawyer finlaysawyer changed the title Capture common HTTP attributes from API Gateway events in Lambda instrumentor Capture common HTTP attributes from API Gateway proxy events in Lambda instrumentor Aug 18, 2022
@finlaysawyer finlaysawyer marked this pull request as ready for review August 18, 2022 19:28
@finlaysawyer finlaysawyer requested a review from a team as a code owner August 18, 2022 19:28
@srikanthccv srikanthccv enabled auto-merge (squash) November 2, 2022 03:57
@srikanthccv srikanthccv merged commit 36264e9 into open-telemetry:main Nov 2, 2022
saartochner-lumigo pushed a commit to lumigo-io/opentelemetry-python-contrib that referenced this pull request Nov 13, 2022
saartochner-lumigo pushed a commit to lumigo-io/opentelemetry-python-contrib that referenced this pull request Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants