Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grpc.aio support #1245

Merged
merged 29 commits into from
Oct 31, 2022
Merged

Commits on Sep 2, 2022

  1. Add support for service-side grpc.aio

    This adds support for grpc.aio server interceptors. The vast majority of
    the code is either re-used wholesale or duplicated with slight modifications
    from the existing standard interceptors.
    cookiefission committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    03e021b View commit details
    Browse the repository at this point in the history
  2. Add grpc.aio client-side support

    This adds support for instrumenting grpc.aio channels with spans and
    telemetry. The instrumentation needed to work differently that the
    standard grpc channel support but is functionally the same.
    cookiefission committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    ff4403c View commit details
    Browse the repository at this point in the history
  3. Fix assorted CI issues

    This fixes assorted issues highlighted by CI, like unused imports,
    import ordering, "malformed" docstrings, etc
    cookiefission committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    a955218 View commit details
    Browse the repository at this point in the history
  4. Add changelog entry

    cookiefission committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    74c857c View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2022

  1. Configuration menu
    Copy the full SHA
    8cd1c9a View commit details
    Browse the repository at this point in the history
  2. Fix conflict properly

    I missed a bit from previous merge conflict resolution..
    cookiefission committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    7802001 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c64b884 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2022

  1. Configuration menu
    Copy the full SHA
    a42dd5d View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2022

  1. Configuration menu
    Copy the full SHA
    1098e64 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2022

  1. Skip grpc.aio tests in Python 3.7

    unittest.IsolatedAsyncioTestCase was introduced in Python 3.8. It's use
    simplifies the grpc.aio tests. Without it, the amount of test code
    increases significantly, with most of the additional code handling
    the asyncio set up.
    cookiefission committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    9cc91b4 View commit details
    Browse the repository at this point in the history
  2. Update filters to handle grpc.aio.ClientCallDetails

    This is the precursor for using the filter mechanisms with the aio
    interceptors.
    
    There's currently a bug in grpc python that means the the
    ClientCallDetails.method field is populated with bytes instead of a
    string. This code handles both cases so that it's forward-compatible
    with a future fixed grpc version.
    cookiefission committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    6c1d0a7 View commit details
    Browse the repository at this point in the history
  3. Update grpc.aio client interceptor to handle grpc bug

    ClientCallDetails.method _should_ be a string here but due to a bug in
    grpc, it is populated with a bytes object. Handle both cases such that we
    are forward-compatible with a fixed version of grpc
    
    More info: grpc/grpc#31092
    cookiefission committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    cf01d06 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2022

  1. Configuration menu
    Copy the full SHA
    600ca83 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c4c2e86 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6622774 View commit details
    Browse the repository at this point in the history
  4. Format code with black

    cookiefission committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    db4f86e View commit details
    Browse the repository at this point in the history
  5. Re-order imports with isort

    This _should_ allow CI to pass now..
    cookiefission committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    5de1a4b View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. Configuration menu
    Copy the full SHA
    ac546be View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4824822 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. Configuration menu
    Copy the full SHA
    94ba2f7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    028a64e View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2022

  1. Configuration menu
    Copy the full SHA
    c9f2a60 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. Configuration menu
    Copy the full SHA
    0935e6a View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. Configuration menu
    Copy the full SHA
    e1304ed View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2022

  1. Configuration menu
    Copy the full SHA
    e30a21b View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2022

  1. Configuration menu
    Copy the full SHA
    274a6f6 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2022

  1. Update CHANGELOG.md

    Add note about adding grpc.aio support
    cookiefission committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    fe3cb18 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    452360d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5a6060d View commit details
    Browse the repository at this point in the history