Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics instrumentation starlette #1327

Merged
merged 17 commits into from
Sep 27, 2022
Merged

Metrics instrumentation starlette #1327

merged 17 commits into from
Sep 27, 2022

Conversation

rahulmukherjee68
Copy link
Contributor

Description

Fixes #1146

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • tox -e test-instrumentation-starlette

Does This PR Require a Core Repo Change?

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added

@rahulmukherjee68 rahulmukherjee68 requested a review from a team as a code owner September 13, 2022 09:07
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 13, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@rahulmukherjee68 rahulmukherjee68 marked this pull request as draft September 14, 2022 06:45
@rahulmukherjee68 rahulmukherjee68 marked this pull request as ready for review September 14, 2022 06:54
@rahulmukherjee68 rahulmukherjee68 requested review from lzchen and srikanthccv and removed request for sanketmehta28, lzchen and srikanthccv September 22, 2022 09:48
lzchen
lzchen reviewed Sep 26, 2022
View reviewed changes
...ntelemetry-instrumentation-starlette/src/opentelemetry/instrumentation/starlette/__init__.py
app.user_middleware = [
x
for x in app.user_middleware
if x.cls is not OpenTelemetryMiddleware
Copy link
Contributor

@lzchen lzchen Sep 26, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do not isinstance() here?

@rahulmukherjee68 rahulmukherjee68 requested review from srikanthccv and sanketmehta28 and removed request for srikanthccv September 27, 2022 05:37
@lzchen lzchen merged commit fc98f08 into open-telemetry:main Sep 27, 2022
saartochner-lumigo pushed a commit to lumigo-io/opentelemetry-python-contrib that referenced this pull request Nov 13, 2022
@rahulmukherjee68
Metrics instrumentation starlette (open-telemetry#1327)
29f9044
saartochner-lumigo pushed a commit to lumigo-io/opentelemetry-python-contrib that referenced this pull request Nov 13, 2022
@rahulmukherjee68
Metrics instrumentation starlette (open-telemetry#1327)
e8676c1
saartochner-lumigo pushed a commit to lumigo-io/opentelemetry-python-contrib that referenced this pull request Nov 13, 2022
@rahulmukherjee68
Metrics instrumentation starlette (open-telemetry#1327)
8ebbe73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv left review comments

@lzchen lzchen lzchen approved these changes

@sanketmehta28 sanketmehta28 sanketmehta28 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metrics instrumentation starlette
4 participants
@rahulmukherjee68 @lzchen @sanketmehta28 @srikanthccv