fix NonRecordSpan.attributes access

[adriangb]

I'm seeing this fail in my test suite:

            duration_attrs[
                SpanAttributes.HTTP_STATUS_CODE
>           ] = span.attributes.get(SpanAttributes.HTTP_STATUS_CODE)
E           AttributeError: 'NonRecordingSpan' object has no attribute 'attributes'

And I can tell that NotRecordingSpan does not have attributes and it seems like that would be checked for. I tried to add a test but with all of the mocking and lack of typing I can't tell what is actually being tested where.

[adriangb]

Seems like this was added in #1230, any thoughts @TheAnshul756?

[srikanthccv]

You are correct, this throws an error in the absence of SDK. Please use span.is_recording() instead.

[adriangb]

I tried that locally and it made some other test fail, we'll see what CI says

[adriangb]

Indeed: https://github.com/open-telemetry/opentelemetry-python-contrib/actions/runs/3193872329/jobs/5212873611#step:6:2637

[TheAnshul756]

Looks like the issue is in the tests. span.is_recording() is false in case of the failed tests. I'm looking into it.

Upd: Span detach was done in patched start_response method and we were trying to access span.is_recordin() after that.

[TheAnshul756]

Hello @adriangb
I've added the fix and want to commit. So should I create a PR on your fork?

[adriangb]

Sure or just merge that and I’ll rebase, either way

[TheAnshul756]

Please merge this PR.

[adriangb]

Please merge this PR.

Done

[adriangb]

Hi is there anything missing to push this forward?

[TheAnshul756]

I think just lint fix and changelog are remaining.