botocore: Add support for SNS publish and publish_batch #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocelotl
reviewed
Nov 16, 2022
...emetry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/extensions/sns.py
Show resolved
Hide resolved
|
Please resolve conflicts ✌️ |
ocelotl
approved these changes
Nov 18, 2022
|
@ocelotl, @srikanthccv can this be merged or does it require any changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an extension to support SNS
publishandpublish_batchservice calls made with botocore and boto3.Included are:
messaging.system,messaging.destination,messaging.destination_kindMessageAttributesin SNS message.This PR follows mostly what is already implemented in the Node.Js AWS SDK instrumentation.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Adds additional unit tests.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.