Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix httpx version #1460

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Fix httpx version #1460

merged 1 commit into from
Nov 21, 2022

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Nov 18, 2022

Fixes #1459

@ocelotl ocelotl requested a review from a team as a code owner November 18, 2022 14:35
@ocelotl ocelotl self-assigned this Nov 18, 2022
@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 18, 2022
aabmass
aabmass reviewed Nov 18, 2022
View reviewed changes
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we leave #1459 open until we actually fix the instrumentation to work with that version?

@lancetarn lancetarn mentioned this pull request Nov 20, 2022
Merged
6 tasks
@ocelotl ocelotl mentioned this pull request Nov 21, 2022
Closed
@ocelotl
Copy link
Contributor Author

ocelotl commented Nov 21, 2022

Can we leave #1459 open until we actually fix the instrumentation to work with that version?

Opened #1463 ✌️

@ocelotl ocelotl requested a review from aabmass November 21, 2022 12:23
@ocelotl ocelotl merged commit 6347ce0 into open-telemetry:main Nov 21, 2022
@rbagd rbagd mentioned this pull request Nov 21, 2022
Merged
12 tasks
@phillipuniverse phillipuniverse mentioned this pull request Apr 6, 2023
Closed
@phillipuniverse
Copy link
Contributor

@lzchen @ocelotl this is the 2nd time a version change like this has bit me, the first one being changed FastAPI requirements. I think that these need to be highlighted much more explicitly in new releases of the otel instrumentation since there is no other way to notify downstream users.

In my case, I am using httpx 0.23.3 and requests were being instrumented ok, but then this version changed and now httpx is silently uninstrumented. I don't configure instrumentation dependencies explicitly as I instead pull in everything via the opentelemetry-instrumentations package.

Could we get some better messaging around when these version requirements change between releases? I'm not sure what the right process is but silently failing can be very frustrating as often you don't realize it until you go and look for the data and it's not there.

@phillipuniverse phillipuniverse mentioned this pull request Apr 7, 2023
Open
@phillipuniverse
Copy link
Contributor

I added more color to a first-class issue report at #1745

@phillipuniverse phillipuniverse mentioned this pull request Apr 12, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@aabmass aabmass Awaiting requested review from aabmass

Assignees

@ocelotl ocelotl

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

httpx tests failing on httpx==0.23.1
4 participants
@ocelotl @phillipuniverse @aabmass @lzchen