opentelemetry-instrumentation-aws-lambda: Adding option to disable context propagation
#1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…context propagation Adding the following option to disable context propagation `disable_aws_context_propagation`. This is similar to the disableAwsContextPropagation option in the nodejs instrumentation.
added 2 commits
November 23, 2022 12:08
ocelotl
approved these changes
Nov 23, 2022
NathanielRN
reviewed
Nov 23, 2022
| @@ -377,11 +393,12 @@ def _instrument(self, **kwargs): | |||
| ) = lambda_handler.rsplit(".", 1) | |||
|
|
|||
| flush_timeout_env = os.environ.get( | |||
| OTEL_INSTRUMENTATION_AWS_LAMBDA_FLUSH_TIMEOUT, "" | |||
| OTEL_INSTRUMENTATION_AWS_LAMBDA_FLUSH_TIMEOUT, None | |||
There was a problem hiding this comment.
Isn't .get without a default None already anyways?
i.e. shouldn't this just be:
os.environ.get(
OTEL_INSTRUMENTATION_AWS_LAMBDA_FLUSH_TIMEOUT
)
NathanielRN
reviewed
Nov 23, 2022
| ) | ||
| flush_timeout = 30000 | ||
| try: | ||
| flush_timeout = int(flush_timeout_env) | ||
| if flush_timeout_env is not None: |
There was a problem hiding this comment.
Why not if flush_timeout_env? Maybe you want to guard against the "" environment variable. But perhaps users would prefer a warning log if they set this variable (which should be an int) to an empty string?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding the following option to disable context propagation
disable_aws_context_propagation. This is similar to the disableAwsContextPropagation option in the nodejs instrumentation.Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.