Instrument newer versions #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Alexandre <miguel.alexandre@bynder.com>
Signed-off-by: Miguel Alexandre <miguel.alexandre@bynder.com>
Signed-off-by: Miguel Alexandre <miguel.alexandre@bynder.com>
Signed-off-by: Miguel Alexandre <miguel.alexandre@bynder.com>
srikanthccv
approved these changes
Nov 28, 2022
Signed-off-by: Miguel Alexandre <miguel.alexandre@bynder.com>
|
Looks like confluent-kafka is still not supported directly on python 3.11 confluentinc/confluent-kafka-python#1452 which causes the tests to fail How should we proceed? |
Signed-off-by: Miguel Alexandre <miguel.alexandre@bynder.com>
|
You can skip the tests on 3.11 and add a FIXME note. |
Signed-off-by: Miguel Alexandre <miguel.alexandre@bynder.com>
|
@srikanthccv I think the last change was enough to disable the tests for 3.11 and pypy (which is not supported and never will be). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The latest confluent-kafka version is 1.9.2, which is not being instrumented due to the current restricted version.
This change increases the confluent-kafka version check to also instrument versions greater or equal to 1.9.0.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Ran the existing unit tests with the changes and it passed. To make sure the
tests were running with the latest confluent-kafka version also hardcoded the
1.9.2version in the requirements and ran the test suite again and the testpassed.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.