-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record exception in Celery instrumentation #1573
Merged
Merged
Commits on Jan 11, 2023
-
Add tests for errors in Celery tasks
I noticed there were no tests for the error scenario in the Celery package. This commit adds a basic test, based on the previous test and how I see other packages test the error status on the span. Part of open-telemetry#987
Configuration menu - View commit details
-
Copy full SHA for 9640486 - Browse repository at this point
Copy the full SHA 9640486View commit details -
Record exception in Celery instrumentation
In addition to setting the status on the span, also record the exception on the span. This adds an event to the span with more details about the error, following the format other instrumentations also use.
Configuration menu - View commit details
-
Copy full SHA for b5e6271 - Browse repository at this point
Copy the full SHA b5e6271View commit details -
Configuration menu - View commit details
-
Copy full SHA for 332bb59 - Browse repository at this point
Copy the full SHA 332bb59View commit details
Commits on Jan 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for efa8942 - Browse repository at this point
Copy the full SHA efa8942View commit details
Commits on Jan 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a6b04af - Browse repository at this point
Copy the full SHA a6b04afView commit details
Commits on Jan 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6c6978e - Browse repository at this point
Copy the full SHA 6c6978eView commit details
Commits on Jan 23, 2023
-
Move Celery error tests to the functional tests
The celery tests failed on Python 3.11. This is most likely due to this issue in billiard, a celery dependency, about it not working on Python 3.11 because of the error reported in the CI: celery/billiard#377 It's been fixed in billiard 4.1.0, but celery is locked on billiard version lower than 4, so it cannot use this version with the fix. This issue does not arise on the Docker tests, because they use Python 3.9.16. I've moved the error test span event assertions to the error test that is available in the functional tests, and removed the unit test. That way, the build will run successfully.
Configuration menu - View commit details
-
Copy full SHA for 2888c12 - Browse repository at this point
Copy the full SHA 2888c12View commit details -
Remove duplicate entry in changelog
This was added in a recent merge commit on this PR branch.
Configuration menu - View commit details
-
Copy full SHA for e5e077c - Browse repository at this point
Copy the full SHA e5e077cView commit details
Commits on Jan 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 04f75ef - Browse repository at this point
Copy the full SHA 04f75efView commit details -
With the move of the tests for tasks with errors to the functional tests, remove the unit test's error task and unused imports.
Configuration menu - View commit details
-
Copy full SHA for c4742f2 - Browse repository at this point
Copy the full SHA c4742f2View commit details
Commits on Jan 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b592c6d - Browse repository at this point
Copy the full SHA b592c6dView commit details
Commits on Feb 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0960b8f - Browse repository at this point
Copy the full SHA 0960b8fView commit details
Commits on Feb 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 26885c4 - Browse repository at this point
Copy the full SHA 26885c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 81f8070 - Browse repository at this point
Copy the full SHA 81f8070View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.