Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record exception in Celery instrumentation #1573

Merged
merged 14 commits into from
Feb 3, 2023

Commits on Jan 11, 2023

  1. Add tests for errors in Celery tasks

    I noticed there were no tests for the error scenario in the Celery
    package. This commit adds a basic test, based on the previous test and
    how I see other packages test the error status on the span.
    
    Part of open-telemetry#987
    tombruijn committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    9640486 View commit details
    Browse the repository at this point in the history
  2. Record exception in Celery instrumentation

    In addition to setting the status on the span, also record the exception
    on the span. This adds an event to the span with more details about the
    error, following the format other instrumentations also use.
    tombruijn committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    b5e6271 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    332bb59 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2023

  1. Configuration menu
    Copy the full SHA
    efa8942 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2023

  1. Configuration menu
    Copy the full SHA
    a6b04af View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2023

  1. Configuration menu
    Copy the full SHA
    6c6978e View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2023

  1. Move Celery error tests to the functional tests

    The celery tests failed on Python 3.11. This is most likely due to this
    issue in billiard, a celery dependency, about it not working on Python
    3.11 because of the error reported in the CI:
    celery/billiard#377
    
    It's been fixed in billiard 4.1.0, but celery is locked on billiard
    version lower than 4, so it cannot use this version with the fix.
    
    This issue does not arise on the Docker tests, because they use Python
    3.9.16.
    
    I've moved the error test span event assertions to the error test that
    is available in the functional tests, and removed the unit test. That
    way, the build will run successfully.
    tombruijn committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    2888c12 View commit details
    Browse the repository at this point in the history
  2. Remove duplicate entry in changelog

    This was added in a recent merge commit on this PR branch.
    tombruijn committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    e5e077c View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. Configuration menu
    Copy the full SHA
    04f75ef View commit details
    Browse the repository at this point in the history
  2. Remove unused test code

    With the move of the tests for tasks with errors to the functional
    tests, remove the unit test's error task and unused imports.
    tombruijn committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    c4742f2 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2023

  1. Configuration menu
    Copy the full SHA
    b592c6d View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2023

  1. Configuration menu
    Copy the full SHA
    0960b8f View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2023

  1. Configuration menu
    Copy the full SHA
    26885c4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    81f8070 View commit details
    Browse the repository at this point in the history