Support aio-pika v8 #1605
Closed
Support aio-pika v8 #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nozik
commented
Jan 29, 2023
| @@ -54,7 +55,10 @@ def setUp(self): | |||
| asyncio.set_event_loop(self.loop) | |||
|
|
|||
| def test_get_publish_span(self): | |||
| exchange = Exchange(CONNECTION, CHANNEL, EXCHANGE_NAME) | |||
| if version.parse(__version__) >= version.parse("8.0.0"): | |||
There was a problem hiding this comment.
The commit for this breaking change - mosquito/aio-pika@c2ee4be
|
There is already a PR for this #1481. |
|
Thanks @srikanthccv . I've added my comments to that PR - I believe there's an issue there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Verify instrumentation support for aio-pika v8.
Fixes # (issue)
N/a
Please delete options that are not relevant.
How Has This Been Tested?
Updated tox.ini to run the tests on both v7 and v8 of the package. Tested manually as well.
Does This PR Require a Core Repo Change?
Checklist: