Add propagator injection for botocore calls #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanielRN
requested review from
toumorokoshi and
lzchen
and removed request for
a team
NathanielRN
force-pushed
the
botocore-propagation-injection
branch
7 times, most recently
from
b78b33a
to
b82627b
Compare
NathanielRN
force-pushed
the
botocore-propagation-injection
branch
from
b82627b
to
8ee114b
Compare
lzchen
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Calls using the
botocoreSDK now use the global propagator to inject context into the request headers before they are sent to AWS.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added a unit test to verify a function which wraps
Endpoint.prepare_requestgets called and inserts a value using the global propagatorChecklist:
See contributing.md for styleguide, changelog guidelines, and more.
- [ ] Documentation has been updated