Make botocore instrumentation check if instrumentation has been suppressed #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanielRN
requested review from
owais and
hectorhdzg
and removed request for
a team
NathanielRN
force-pushed
the
suppress-downstream-botocore-instrumentation
branch
from
b0c02de
to
3b0e1e7
Compare
owais
approved these changes
Nov 13, 2020
lzchen
approved these changes
Nov 13, 2020
NathanielRN
force-pushed
the
suppress-downstream-botocore-instrumentation
branch
3 times, most recently
from
de6291e
to
0704b64
Compare
NathanielRN
force-pushed
the
suppress-downstream-botocore-instrumentation
branch
from
0704b64
to
5c14227
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to the PR originally submitted by @wangzlei that was on the Core repo: open-telemetry/opentelemetry-python#1291
By checking if instrumentation has been suppressed, we avoid double instrumentation if a call is already being traced from some other package.
Type of change
How Has This Been Tested?
Added a unit test which checks that the flag is used to stop further instrumentation.
Checklist:
- [ ] Documentation has been updated