Update pymemcache instrumentation to follow semantic conventions #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srikanthccv
requested review from
codeboten and
aabmass
and removed request for
a team
|
cc @lzchen |
lzchen
reviewed
Nov 16, 2020
| @@ -115,7 +114,7 @@ def wrapper(wrapped, instance, args, kwargs): | |||
| @_with_tracer_wrapper | |||
| def _wrap_cmd(tracer, cmd, wrapped, instance, args, kwargs): | |||
| with tracer.start_as_current_span( | |||
| _CMD, kind=SpanKind.INTERNAL, attributes={} | |||
| cmd, kind=SpanKind.CLIENT, attributes={} | |||
| ) as span: | |||
There was a problem hiding this comment.
From before, does pymemcache not have the concept of name?
There was a problem hiding this comment.
I am not sure if I understood you correctly, but memcache supports this list of commands. We are using the command as a span name.
There was a problem hiding this comment.
Sorry I was referring to adding the db.name attribute. We should have it as a span attribute and also use it as a span name fallback if the command isn't present for some reason.
There was a problem hiding this comment.
No, it doesn't have any concept of databases that can be used for db.name.
lzchen
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #159
Type of change
How Has This Been Tested?
tox -e test-instrumentation-pymemcache