Add AWS X-Ray Ids Generator Entry Point #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanielRN
requested review from
toumorokoshi and
ocelotl
and removed request for
a team
NathanielRN
force-pushed
the
ids-generator-entry-point
branch
from
e91cf4f
to
9e020af
Compare
NathanielRN
force-pushed
the
ids-generator-entry-point
branch
from
9e020af
to
564e74f
Compare
codeboten
approved these changes
Nov 23, 2020
aabmass
approved these changes
Nov 23, 2020
AzfaarQureshi
pushed a commit
to open-o11y/opentelemetry-python-contrib
that referenced
this pull request
Nov 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In response to open-telemetry/opentelemetry-python#1404, it is convenient to be able to auto instrument the AWS SDK Extension by adding
AwsXrayIdsGeneratoras an entry point.Type of change
How Has This Been Tested?
A test in open-telemetry/opentelemetry-python#1404 covers using an environment variable to find and set a
CustomIdsGenerator.Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.
- [ ] Unit tests have been added- [ ] Documentation has been updated