Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return none for Getter if key does not exist #233

Merged
merged 12 commits into from
Dec 8, 2020
Merged

Return none for Getter if key does not exist #233

merged 12 commits into from
Dec 8, 2020

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Dec 4, 2020

@lzchen lzchen requested a review from a team as a code owner December 4, 2020 18:37
@lzchen lzchen requested review from toumorokoshi and ocelotl and removed request for a team December 4, 2020 18:37
codeboten
codeboten reviewed Dec 7, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are tests already catching this? If not it would be good to have tests that do.

@lzchen
Copy link
Contributor Author

lzchen commented Dec 7, 2020

@codeboten
For asgi, the test is already covering this but I added headers for a more explicit check. For celery and wsgi, those cases will be covered by the propagator tests.

@lzchen
Copy link
Contributor Author

lzchen commented Dec 7, 2020

@codeboten
Nvm, I added tests.

@lzchen lzchen merged commit 3eb27ca into open-telemetry:master Dec 8, 2020
@lzchen lzchen deleted the prop branch December 8, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@toumorokoshi toumorokoshi Awaiting requested review from toumorokoshi

@ocelotl ocelotl Awaiting requested review from ocelotl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lzchen @codeboten