Fix AttributeError: __aexit__ for aiopg.connect and aiopg.create_pool #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srikanthccv
requested review from
codeboten and
lzchen
and removed request for
a team
|
More context: Here is the actual implementation of aiopg which returns the context manager for .connect and .create_pool |
|
roses are red, ci is green, review this sometime maybe? |
lzchen
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Function
async def wrap_connect_(...)used for patchwrapt.wrap_function_wrapper(aiopg, "connect", wrap_connect_)is an awaitable function. It works when aiopg is connection is made using awaitconn = await aiopg.connect(...)but raises error when used with context managerasync with aiopg.connect(...) as conn.It is very common to use with context manager to automatically close conn. This makes the change from awaitable function to context manager for both
aiopg.connectandaiopg.create_pool. It works for both the cases.Fixes open-telemetry/opentelemetry-python#1448
Type of change
How Has This Been Tested?
tox -e test-instrumentation-aiopg