Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elasticsearch: tests against elasticsearch 8 #2420

Merged
merged 3 commits into from
May 14, 2024
Merged

elasticsearch: tests against elasticsearch 8 #2420

merged 3 commits into from
May 14, 2024

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Apr 15, 2024 •
edited
Loading

Description

Test against recent elasticsearch versions

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@xrmx xrmx force-pushed the tests-against-elasticsearch-7-8 branch from b363792 to ae58576 Compare April 15, 2024 14:21
pquentin
pquentin reviewed Apr 17, 2024
View reviewed changes
Copy link
Contributor

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes make sense to me.

instrumentation/opentelemetry-instrumentation-elasticsearch/test-requirements-8.txt Outdated Show resolved Hide resolved
instrumentation/opentelemetry-instrumentation-elasticsearch/tests/test_elasticsearch.py Outdated Show resolved Hide resolved
instrumentation/opentelemetry-instrumentation-elasticsearch/tests/test_elasticsearch.py Outdated Show resolved Hide resolved
instrumentation/opentelemetry-instrumentation-elasticsearch/tests/test_elasticsearch.py Outdated Show resolved Hide resolved
instrumentation/opentelemetry-instrumentation-elasticsearch/tests/test_elasticsearch.py Outdated Show resolved Hide resolved
@xrmx xrmx force-pushed the tests-against-elasticsearch-7-8 branch 2 times, most recently from 4b3f945 to 29f570b Compare April 29, 2024 12:45
@xrmx xrmx changed the title WIP elasticsearch: tests against elasticsearch 7 and 8 WIP elasticsearch: tests against elasticsearch 8 Apr 29, 2024
@xrmx xrmx force-pushed the tests-against-elasticsearch-7-8 branch 4 times, most recently from 1a619e1 to 520de9f Compare May 2, 2024 15:26
@xrmx xrmx mentioned this pull request May 6, 2024
Closed
@xrmx xrmx force-pushed the tests-against-elasticsearch-7-8 branch 2 times, most recently from df7438e to 503e95d Compare May 6, 2024 16:33
@xrmx xrmx marked this pull request as ready for review May 6, 2024 16:34
@xrmx xrmx requested a review from a team as a code owner May 6, 2024 16:34
@xrmx xrmx changed the title WIP elasticsearch: tests against elasticsearch 8 elasticsearch: tests against elasticsearch 8 May 6, 2024
@xrmx xrmx force-pushed the tests-against-elasticsearch-7-8 branch 2 times, most recently from 1d1c48f to 92b2699 Compare May 7, 2024 08:50
@xrmx xrmx requested a review from pquentin May 8, 2024 10:21
@xrmx xrmx force-pushed the tests-against-elasticsearch-7-8 branch from 92b2699 to 16ca574 Compare May 13, 2024 12:27
@ocelotl ocelotl merged commit 6a40ffd into open-telemetry:main May 14, 2024
314 checks passed
pquentin
pquentin reviewed May 15, 2024
View reviewed changes
Copy link
Contributor

@pquentin pquentin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM too. Thanks for fixing the mock to be correct for urllib3 nodes.

shadchin pushed a commit to shadchin/opentelemetry-python-contrib that referenced this pull request May 29, 2024
@xrmx @shadchin
elasticsearch: tests against elasticsearch 8 (open-telemetry#2420)
5e6daf3 
* elasticsearch: bump handled version to 6.0

After 4de0e56

* elasticsearch: tests against elasticsearch 8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin left review comments

@ocelotl ocelotl ocelotl approved these changes

@tammy-baylis-swi tammy-baylis-swi tammy-baylis-swi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xrmx @pquentin @ocelotl @tammy-baylis-swi