Preserve brackets around literal IPv6 hosts #2552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-hutchinson
force-pushed
the
fix-ipv6-url-credentials
branch
from
7119d30
to
597eb52
Compare
tim-hutchinson
changed the title
tim-hutchinson
changed the title
lzchen
approved these changes
May 24, 2024
shadchin
pushed a commit
to shadchin/opentelemetry-python-contrib
that referenced
this pull request
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2551
When a literal IPv6 address is in the url,
remove_url_credentialsdrops the[ ]around the hostname needed for disambiguation.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added unit tests for the
remove_url_credentialsfunction to cover hostname + ipv4 and ipv6 cases.Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.