Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unrelated packages from test requirements #2559

Merged
merged 4 commits into from
May 29, 2024

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented May 28, 2024

Description

Remove random packages from test requirements of boto, botocore and threading instrumentations. pypy3 now can install boto and botocore test requirements. Unfortunately is still crashing when trying to run boto and botocore tests but it works fine with boto3sqs so reenable it.

Refs #1736

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 28, 2024
@xrmx xrmx requested a review from a team as a code owner May 28, 2024 08:54
@xrmx xrmx force-pushed the cleanup-packages-1736 branch 3 times, most recently from 13e552c to 3b6488d Compare May 28, 2024 09:10
@ocelotl ocelotl merged commit bd9156f into open-telemetry:main May 29, 2024
314 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants