-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds NoOpTracerProvider test case for botocore instrumentation #2586
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In #2605 we updated moto
package. You'll need to fix conflicts and update your tests accordingly
be1e3ca
to
b2b1d22
Compare
@emdneto |
4e4ffa0
to
8612ef7
Compare
8612ef7
to
82a64da
Compare
Signed-off-by: Shwejan Bhupathi <Bhupathi.ShwejanRaj@fmr.com>
Signed-off-by: Shwejan Bhupathi <Bhupathi.ShwejanRaj@fmr.com>
Signed-off-by: Shwejan Bhupathi <Bhupathi.ShwejanRaj@fmr.com>
82a64da
to
bae1df1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase and then allow maintainer edits so we can rebase for you.
Are you still working on this? |
Description
Adds NoOpTracerProvider test cases for botocore instrumentation.
Fixes #988
How Has This Been Tested?
tox -e test-instrumentation-botocore
Does This PR Require a Core Repo Change?
No.