Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds NoOpTracerProvider test case for botocore instrumentation #2586

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

shwejanraj
Copy link
Contributor

Description

Adds NoOpTracerProvider test cases for botocore instrumentation.

Fixes #988

How Has This Been Tested?

tox -e test-instrumentation-botocore

Does This PR Require a Core Repo Change?

No.

@shwejanraj shwejanraj changed the title Adds NoOpTracer test case for botocore instrumentation Adds NoOpTracerProvider test case for botocore instrumentation Jun 7, 2024
Copy link
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #2605 we updated moto package. You'll need to fix conflicts and update your tests accordingly

@brianwarner brianwarner force-pushed the 988-Adds-NoOpTracerProvider-test-cases-for-botocore-instrumentation branch from be1e3ca to b2b1d22 Compare June 21, 2024 12:00
@brianwarner brianwarner requested a review from a team as a code owner June 21, 2024 12:00
@shwejanraj
Copy link
Contributor Author

@emdneto
I have updated the test cases accordingly. Could you please take a moment to review it.

@shwejanraj shwejanraj force-pushed the 988-Adds-NoOpTracerProvider-test-cases-for-botocore-instrumentation branch 2 times, most recently from 4e4ffa0 to 8612ef7 Compare June 22, 2024 06:54
@shwejanraj shwejanraj requested a review from emdneto June 22, 2024 06:54
@shwejanraj shwejanraj force-pushed the 988-Adds-NoOpTracerProvider-test-cases-for-botocore-instrumentation branch from 8612ef7 to 82a64da Compare June 24, 2024 07:22
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Shwejan Bhupathi <Bhupathi.ShwejanRaj@fmr.com>
Signed-off-by: Shwejan Bhupathi <Bhupathi.ShwejanRaj@fmr.com>
Signed-off-by: Shwejan Bhupathi <Bhupathi.ShwejanRaj@fmr.com>
@brianwarner brianwarner force-pushed the 988-Adds-NoOpTracerProvider-test-cases-for-botocore-instrumentation branch from 82a64da to bae1df1 Compare July 9, 2024 15:15
Copy link
Contributor

@lzchen lzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase and then allow maintainer edits so we can rebase for you.

@lzchen
Copy link
Contributor

lzchen commented Jul 22, 2024

@shwejanraj

Are you still working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit and test opentelemetry-instrumentation-botocore
3 participants