Added recording of exceptions in Pyramid #2622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Only internal errors and exceptions are recorded * Status description is updated in case of an error * Unit tests added
1 task
xrmx
reviewed
Jun 20, 2024
instrumentation/opentelemetry-instrumentation-pyramid/tests/test_programmatic.py
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-pyramid/tests/test_programmatic.py
Show resolved
Hide resolved
lzchen
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adapts the instrumentation of Pyramid applications so that traces would contain information on uncaught exceptions or errors while serving a request. This is similar to what is done in the generic
OpenTelemetryMiddlewarefor WSGI apps, which is not used in Pyramid instrumentation.Fixes #2619
Type of change
How Has This Been Tested?
Unit tests added to ensure information on exceptions is present in generated traces. Only HTTP 5xx-like responses should generate such exceptions.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.