Confluent Kafka: Ensure consume span is ended when consumer is closed #2640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshschltelus
changed the title
xrmx
approved these changes
Jun 27, 2024
emdneto
reviewed
Jun 27, 2024
instrumentation/opentelemetry-instrumentation-confluent-kafka/tests/test_instrumentation.py
Show resolved
Hide resolved
emdneto
approved these changes
Jun 27, 2024
lzchen
approved these changes
Jun 27, 2024
lzchen
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix an issue with the confluent kafka instrumentation where the consume span created after a message is received is not closed when the consumer is closed
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added a unit test for close and tested with
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.