Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redis: fix default port KeyError, wrong attr name #265

Merged
merged 5 commits into from
Apr 14, 2021
Merged

redis: fix default port KeyError, wrong attr name #265

merged 5 commits into from
Apr 14, 2021

Conversation

shlee322
Copy link
Contributor

@shlee322 shlee322 commented Dec 18, 2020 •
edited
Loading

Description

  • fix default port KeyError
  • wrong attr name (net.peer.ip -> net.peer.port)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@shlee322 shlee322 requested a review from a team as a code owner December 18, 2020 08:06
@shlee322 shlee322 requested review from aabmass and hectorhdzg and removed request for a team December 18, 2020 08:06
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 18, 2020 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@shlee322 shlee322 marked this pull request as draft December 18, 2020 08:27
codeboten
codeboten approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @shlee322! Can you update the changelog

@shlee322 shlee322 marked this pull request as ready for review December 18, 2020 17:00
@shlee322 shlee322 marked this pull request as draft December 31, 2020 13:23
@codeboten
Copy link
Contributor

@shlee322 looks like the docker-tests will need to be fixed as well before this PR can move forward.

Base automatically changed from master to main January 29, 2021 19:28
@lzchen
Copy link
Contributor

lzchen commented Feb 24, 2021

@shlee322
Are you still working on this?

@shlee322
Copy link
Contributor Author

@lzchen
Sorry. I'll fix it this week.

@lzchen
Copy link
Contributor

lzchen commented Apr 8, 2021

@shlee322
Is this still being worked on?

@srikanthccv srikanthccv mentioned this pull request Apr 11, 2021
Open
@codeboten codeboten marked this pull request as ready for review April 14, 2021 15:32
@codeboten codeboten merged commit 08682f6 into open-telemetry:main Apr 14, 2021
@codeboten
Copy link
Contributor

Thanks for the contribution @shlee322, I updated the tests for docker and found another issue to fix at the same time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@lzchen lzchen lzchen approved these changes

@aabmass aabmass Awaiting requested review from aabmass

@hectorhdzg hectorhdzg Awaiting requested review from hectorhdzg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shlee322 @codeboten @lzchen