Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point pylint to the root directory of every package #2658

Merged
merged 10 commits into from
Jul 3, 2024
Merged

Point pylint to the root directory of every package #2658

merged 10 commits into from
Jul 3, 2024

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Jul 2, 2024

Fixes #2657

@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 2, 2024
@ocelotl ocelotl self-assigned this Jul 2, 2024
@ocelotl ocelotl requested a review from a team as a code owner July 2, 2024 22:00
@ocelotl ocelotl mentioned this pull request Jul 2, 2024
Open
@xrmx
Copy link
Contributor

xrmx commented Jul 3, 2024

Now it's only matter of fixing hundreds warnings 😅

@ocelotl ocelotl mentioned this pull request Jul 3, 2024
Merged
@ocelotl
Copy link
Contributor Author

ocelotl commented Jul 3, 2024

Now it's only matter of fixing hundreds warnings 😅

Right, 😆

Apparently that happened because I forgot to tell pylint to use the configuration file, after I fixed that the amount of failures dropped to just 6 failed lint jobs.

@ocelotl ocelotl changed the title Point pylint to the root directories Point pylint to the package root directories Jul 3, 2024
@ocelotl ocelotl merged commit a924777 into open-telemetry:main Jul 3, 2024
379 checks passed
@ocelotl ocelotl deleted the issue_2657 branch July 3, 2024 22:22
@ocelotl ocelotl changed the title Point pylint to the package root directories Point pylint to the root directory of every package Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tammy-baylis-swi tammy-baylis-swi tammy-baylis-swi approved these changes

Assignees

@ocelotl ocelotl

@NathanielRN NathanielRN

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pylint is not pointing to the root directory of every package
4 participants
@ocelotl @xrmx @tammy-baylis-swi @NathanielRN