Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Celery: Add support for new major version 5.x #266

Merged
merged 3 commits into from
Dec 22, 2020

Conversation

adamantike
Copy link
Contributor

Description

Add support for Celery v5, which apparently didn't introduce changes that affect the current instrumentation code [0].

[0] https://github.com/celery/celery/blob/master/Changelog.rst#500

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested locally using:

tox -e test-instrumentation-celery

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@adamantike adamantike requested a review from a team as a code owner December 18, 2020 14:42
@adamantike adamantike requested review from owais and lzchen and removed request for a team December 18, 2020 14:42
Add support for Celery v5, which apparently didn't introduce changes that
affect the current instrumentation code [0].

[0] https://github.com/celery/celery/blob/master/Changelog.rst#500
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@codeboten codeboten merged commit f9ea61c into open-telemetry:master Dec 22, 2020
@adamantike adamantike deleted the celery5 branch January 25, 2021 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants