Use instanceof to check if responses are valid Response objects #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThePumpingLemma
requested review from
owais and
hectorhdzg
and removed request for
a team
ThePumpingLemma
force-pushed
the
check-response-type
branch
2 times, most recently
from
b800adc
to
9670a95
Compare
lzchen
approved these changes
Jan 5, 2021
owais
approved these changes
Jan 7, 2021
|
@ThePumpingLemma |
There are some exception types that set the response attribute to a non-Response type, e.g. "AttributeError: 'dict' object has no attribute 'status_code'"
ThePumpingLemma
force-pushed
the
check-response-type
branch
from
6e40d53
to
645aec5
Compare
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some exception types that set the response attribute to a
non-Response type, e.g. "AttributeError: 'dict' object has no attribute
'status_code'"
Description
At $WORK, we have an integration with a vendor (i.e. POST calls via
requests) that will fail once-in-a-while with an exception where theresponseattribute on the exception is a dictionary instead of aResponseobject. Because the instrumentation doesn't have a type check, it tries to get thestatus_codeattribute from the dictionary and fails with anAttributeError. Since it swallows the exception thrown fromrequests, we can't easily debug it (vendor issue is not easily reproducible). This change will allow the instrumentation to work in this edge case.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.